Draft of issues fixed #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousleo
reviewed
May 13, 2020
curiousleo
reviewed
May 13, 2020
curiousleo
reviewed
May 13, 2020
curiousleo
reviewed
May 13, 2020
curiousleo
reviewed
May 13, 2020
CHANGELOG.md
Outdated
| [26](https://github.com/haskell/random/issues/26) | Add Random instances for tuples | | ||
| [44](https://github.com/haskell/random/issues/44) | Add Random instance for Natural | | ||
| [51](https://github.com/haskell/random/issues/51) | Very low throughput | | ||
| [53](https://github.com/haskell/random/issues/53) | incorrect distribution of randomR for floating-point numbers | Fixed |
There was a problem hiding this comment.
Suggested change
| [53](https://github.com/haskell/random/issues/53) | incorrect distribution of randomR for floating-point numbers | Fixed | |
| [53](https://github.com/haskell/random/issues/53) | incorrect distribution of randomR for floating-point numbers | Documented behaviour of floating point numbers |
We haven't actually done this yet :) I'll create a PR.
There was a problem hiding this comment.
Ooh yes we meant to do it - thanks
There was a problem hiding this comment.
I've started writing a little Haddock section for this. I'll create a PR once I have a draft.
curiousleo
reviewed
May 13, 2020
curiousleo
reviewed
May 13, 2020
curiousleo
reviewed
May 13, 2020
curiousleo
reviewed
May 13, 2020
|
I might squash all the commits before making a PR |
curiousleo
approved these changes
May 15, 2020
There was a problem hiding this comment.
Just one Markdown formatting nit - otherwise this is great, thank you!
Edit: I just committed my formatting suggestions to the branch in dd39abb.
I think that would be a good idea :) |
idontgetoutmuch
force-pushed
the
issues-in-changelog
branch
from
dd39abb to
37f2271
Compare
curiousleo
pushed a commit
that referenced
this pull request
May 19, 2020
curiousleo
pushed a commit
that referenced
this pull request
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.