Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override output_path if provided in Trainer init and use temp folder for test outputs #12

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

eginhard
Copy link
Member

  • Previously, Trainer(..., output_path=...) would not actually have an effect and the value from the config was used
  • Tests now use a temp folder for their outputs, so that the user's folder is not cluttered

torch.cuda.amp.GradScaler(args...) and torch.cpu.amp.GradScaler(args...) will be
deprecated. Please use torch.GradScaler("cuda", args...) or
torch.GradScaler("cpu", args...) instead.

https://pytorch.org/docs/stable/amp.html

torch.GradScaler is only available from torch>=2.3, so need to use a
conditional and in type hints it needs to be surrounded by quotes.
@eginhard eginhard merged commit 8e4d2a1 into main Nov 13, 2024
@eginhard eginhard deleted the tmp_outputs branch November 13, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants