Move from setup.py to pyproject.toml, simplify requirements #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eginhard
force-pushed
the
toml
branch
9 times, most recently
from
e91da21 to
ee5b402
Compare
Automatic changes from: pre-commit run --all-files
Having this file is still useful to allow installing *only* dev requirements (e.g. in CI) with: pip install -r requirements.dev.txt Generate that file automatically from the pyproject.toml based on: https://github.com/numpy/numpydoc/blob/e7c6baf00f5f73a4a8f8318d0cb4e04949c9a5d1/tools/generate_requirements.py
Otherwise a form of this issue occurs due to older setuptools not supporting pyproject.toml: pypa/setuptools#3269 Might be resolved on Ubuntu 24.04 images.
eginhard
force-pushed
the
toml
branch
3 times, most recently
from
7096ad8 to
bbb9768
Compare
Minimum torch version is 2.1 now.
[ci skip]
[ci skip]
Colombine-cyber
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit because it includes one automatic style change that touched many files.
Moving (as far as possible) from
setup.pytopyproject.tomlmakes the information easier to understand and helped to remove some obsolete code. It also made it easier to consolidate the dependencies and move more of them into optional extras (mainly language-specific libraries for Bangla/Chinese/Korean G2P) so that the default install becomes leaner.