Upgrade to version 8.11.0, fix log4j and Debian 11 bullseye support #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to version 8.11.0, fix log4j and Debian 11 bullseye support
antonioarenzanapulido
requested review from
dortegau,
frantsao,
jmonterrubio,
sorobon,
vicsufer,
blalop and
xtianae7
sorobon
approved these changes
Dec 20, 2021
blalop
reviewed
Dec 20, 2021
tasks/config.yml
Outdated
| @@ -35,6 +35,10 @@ | |||
| force: true | |||
| notify: restart Solr | |||
|
|
|||
| - name: Solr | Gather OS specific vars | |||
| include_vars: "{{ ansible_distribution }}-{{ ansible_distribution_major_version }}.yml" | |||
| when: ansible_facts['distribution'] == "Debian" and ansible_facts['distribution_major_version'] == "11" | |||
There was a problem hiding this comment.
A bit of personal preference: I think this may be too tied to the case of Debian 11. I would rather generate a vars file to each single distro we support so it can be easily read.
There was a problem hiding this comment.
Yes, I also think this would be cleaner, made a commit :)
blalop
approved these changes
Dec 20, 2021
|
Could you update the pip requirements? |
emepege
approved these changes
Dec 20, 2021
|
Updated pip dependencies :) |
dortegau
approved these changes
Dec 20, 2021
antonioarenzanapulido
force-pushed
the
develop
branch
from
9903f5f to
f3107b1
Compare
xtianae7
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Upgrade to version 8.11.0, fix log4j and Debian 11 bullseye support
Benefits
Possible Drawbacks
Applicable Issues
#141