Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#138 Add support for Adoptopenjdk and Corretto #139

Merged
merged 19 commits into from
Sep 7, 2020
Merged

Conversation

vicsufer
Copy link
Collaborator

@vicsufer vicsufer commented Sep 3, 2020

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

Use files in /vars to load specific jdk build variables, use a default variable to decided which file, by default openjdk.
Also made travis to run all test scenarios instead of just the default one.

Benefits

Add support to install adoptopenjdk and corretto

Possible Drawbacks

N/A

Applicable Issues

#138

@vicsufer vicsufer self-assigned this Sep 4, 2020
@vicsufer vicsufer marked this pull request as ready for review September 4, 2020 10:22
@vicsufer vicsufer merged commit f546b3e into develop Sep 7, 2020
@sorobon sorobon deleted the feature/138 branch September 7, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants