Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#81 add log path variable in defaults #82

Merged
merged 2 commits into from
Aug 24, 2021
Merged

#81 add log path variable in defaults #82

merged 2 commits into from
Aug 24, 2021

Conversation

blalop
Copy link
Member

@blalop blalop commented Aug 23, 2021

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;
  • Add "idealista/benders" as reviewer

Description of the Change

Define app_log_path in the defaults so no errors arise when defining log paths.

Benefits

More informative defaults, error-prone behaviour corrected.

Possible Drawbacks

N/A

Applicable Issues

#81

@blalop blalop merged commit ff5533b into develop Aug 24, 2021
@blalop blalop deleted the bugs/81 branch August 24, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants