Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clickhouse_keeper and default replica params #63

Conversation

jbuckmccready
Copy link
Contributor

@jbuckmccready jbuckmccready commented Nov 15, 2023

Description of the Change

Added Clickhouse Keeper and default replica parameters to config generation.

#64

@ultraheroe ultraheroe added the enhancement New feature or request label Nov 16, 2023
@ultraheroe ultraheroe changed the base branch from main to develop November 16, 2023 10:36
@gallejesus gallejesus self-requested a review November 16, 2023 16:48
@gallejesus
Copy link
Contributor

gallejesus commented Nov 16, 2023

I believe it should also include the Keeper nodes config (host & port) in config.xml.j2 so all CH nodes know where Keeper is, similar to what's doing with ZK

@jbuckmccready
Copy link
Contributor Author

jbuckmccready commented Nov 16, 2023

The Clickhouse Keeper config section only goes in the config for the nodes which are running keeper (not all the nodes like the zoo keeper config).

E.g., if you have a cluster of 4 data nodes and separately run 3 nodes with keeper on them then the zoo keeper config goes in all 7 nodes configs, but the keeper config only goes in the 3 keeper nodes.

The cluster nodes use the zoo keeper config to contact the keeper nodes (clickhouse keeper requires the zoo keeper config to be present).

@gallejesus
Copy link
Contributor

gallejesus commented Nov 17, 2023

Yes, I see there is an alternative config using <keeper> tags , so both configs are valid https://github.com/ClickHouse/ClickHouse/blob/master/tests/integration/test_alternative_keeper_config/test.py

@ultraheroe ultraheroe merged commit 29b5f89 into idealista:develop Nov 17, 2023
ultraheroe added a commit that referenced this pull request Nov 17, 2023
Update role with changes in #62 and #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants