Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Update to use ansible_os_family var instead of ansible_distribution var for main.yml #65

Closed
ultraheroe opened this issue Nov 17, 2023 · 0 comments · Fixed by #66
Closed

[REFACTOR] Update to use ansible_os_family var instead of ansible_distribution var for main.yml #65

ultraheroe opened this issue Nov 17, 2023 · 0 comments · Fixed by #66
Labels
enhancement New feature or request

Comments

@ultraheroe
Copy link
Member

Description

os_distribution will resolve to the actual operation system name.
E.g.: for ubuntu, the code will try to include install-Ubuntu.yml

This fixes the include file for Ubuntu as well

Link/s to the specific code that needs a refactor (if applicable)

main.yml

Reported and PR by @xterr in #62
@ultraheroe ultraheroe added the enhancement New feature or request label Nov 17, 2023
@ultraheroe ultraheroe mentioned this issue Nov 17, 2023
Merged
ultraheroe added a commit that referenced this issue Nov 17, 2023
@ultraheroe
Merge pull request #62 from xterr/patch-1
cb79224 
Update main.yml #65
@ultraheroe ultraheroe changed the title [REFACTOR] Update to use os_distribution var instead of ansible_distribution var for main.yml [REFACTOR] Update to use ansible_os_family var instead of ansible_distribution var for main.yml Nov 17, 2023
@ultraheroe ultraheroe mentioned this issue Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update role with changes in #62 and #63 idealista/clickhouse_role
1 participant
@ultraheroe