Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Footnotes implementation #78

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Basic Footnotes implementation #78

wants to merge 9 commits into from

Conversation

ralsina
Copy link
Contributor

@ralsina ralsina commented Mar 7, 2025 •
edited
Loading

This PR contains the beginnings of footnotes implementation:

  • Only supports footnotes with a single reference (should support multiple)
  • Footnote definitions only allow inline elements (should allow blocks)
  • The generated HTML is not perfectly as per spec

BUT for the basic case 1 it works

Footnotes

  1. Something like this ↩

@trafico-bot trafico-bot bot added the 🚧 WIP Still work-in-progress, please don't review and don't merge label Mar 7, 2025
@icyleaf icyleaf mentioned this pull request Mar 9, 2025
Open
7 tasks
@ralsina ralsina changed the title WIP: Footnotes implementation Basic Footnotes implementation Mar 13, 2025
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Mar 13, 2025
@ralsina ralsina marked this pull request as ready for review March 14, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔍 Ready for Review Pull Request is not reviewed yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ralsina