Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the implemented ros2 packages to work with moveit2 #10

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

martinaxgloria
Copy link
Member

As per title. It includes the following ROS2 packages:

  • icub_moveit_config: it contains the configuration files used by MoveIt to load and run iCubV2_5 model on rviz;
  • ergocub_moveit_config: the same as above, but for ergocub;
  • icub_moveit: it contains icub.launch.py launch file used to launch all the ros2 nodes needed for the simulation;
  • icub_controller: pkg that handles the ros2_control framework.

I also updated the README.md file with a more detailed description of how to install and use the simulation so far.

Add first attempt of icub_controller

Fix icub_controller code

Fix

Correctly loading and activate the controller

Refactoring launch_icub.launch.py as the main one launch file in order to make the l_arm_controller works

Update README.md

Substitute iCub3 with iCub2_5 urdf and configuration files

Create two different ros2_control macro to handle two controllers

Add ergoCub configuration files

Add a ros2_controller for each part

Modify ergocub_moveit_config in order to add a controller for each part

Change names from 'l/r_<part>' to 'left/right_<part>'
Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

My only concern is that we are adding a icub_robot.urdf, it can't use the urdf installed by icub-models?
Because it would be difficult to maintain this copy of the urdf

@martinaxgloria
Copy link
Member Author

You're right @Nicogene. So far, this urdf is used by spaw_icub.py which is an executable used to spawn the icub model on gazebo when the proper node is launched. I'm going to make some changes in order to use the one in icub-models instead of adding this urdf

@martinaxgloria
Copy link
Member Author

Hi @Nicogene, with 1639e45 I removed something that is not used and I modified the executable to spawn the icub model on gazebo using the .urdf.xacro file generated by the moveit setup assistant which relies on the urdf in icub-models

@Nicogene Nicogene merged commit 2ad11b0 into master Sep 5, 2023
@Nicogene Nicogene deleted the feat/controller branch September 5, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants