Replace singletons with DI patterns... #3314
Conversation
clean.cmd
Outdated
| @@ -0,0 +1,22 @@ | |||
| @ECHO OFF | |||
There was a problem hiding this comment.
what's the purpose of this script? Isn't git clean sufficient?
There was a problem hiding this comment.
Oops, that was not intended to be included, I'll remove it
There was a problem hiding this comment.
But git clean does either too much or too less... this one removes exactly the bin and obj folders.
There was a problem hiding this comment.
e.g. It would also remove my Resharper configuration which I'm not allowed to commit.
There was a problem hiding this comment.
that's why I use git clean -X, which removes only files that match .gitignore entries, but does NOT touch untracked files. I have lots of untracked extra files in my ILSpy folder (test cases, diff files, TODO lists, notes, etc.), which some might argue is a bad thing, but I don't care :)
see https://git-scm.com/docs/git-clean
Usually, I combine that with d to remove empty directories and q for "quiet mode" and f is mandatory anyway. So, I use git clean -Xdfq.
Just configure your .gitignore correctly and git clean behaves exactly as it is intended by its creators.
There was a problem hiding this comment.
Just remember to always use upper-case X and you will be fine.
There was a problem hiding this comment.
If you think our .gitignore file is missing something, feel free to extend it to match your needs.
ILSpy/AboutPage.cs
Outdated
| new RequestNavigateEventArgs(new Uri("resource://aboutpage"), null), | ||
| inNewTabPage: true | ||
| ); | ||
| assemblyTreeModel.NavigateTo(new(new("resource://aboutpage"), null), inNewTabPage: true); |
There was a problem hiding this comment.
I cannot say that I am very happy about the removed type names, but I guess that's the modern style...
There was a problem hiding this comment.
I'll try to change the .editorconfig defaults to not suggest removing types with the next commit
|
Thank you for the good work... just a few notes:
|
- Decouple services to reduce circular dependencies - Move update panel to a separate control - Remove unrelated methods from MainWindow
tom-englert
force-pushed
the
dev/DependencyInjection
branch
from
e38ed25 to
a24e0f9
Compare
|
Issues fixed... |
|
Thank you very much! |
... and decouple the direct dependencies of the services.
Again this is only architectural changes in the UI layer, no functional changes.
I tried to break it down into comprehensible steps per commit, however due to the many side effects the first ones are still big, sorry for that.