Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty version directories of dotnet #3265

Conversation

Herrmel
Copy link
Contributor

@Herrmel Herrmel commented Aug 19, 2024

#3261

Problem

Dotnet core assemblies can not be resolved if empty folders of previously installed versions exist.

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.
    Ignore empty Directories
  • Which part of this PR is most in need of attention/improvement?
    I changed the result of ConvertToVersion only check for empty directories where the directory is considered a fitting version. I hope that is fine.
    In my case the version directories where completly empty but maybe it would make sense to look for at least one file that does have .dll or .exe extension?
  • At least one test covering the code changed
    I'm not sure how to test things that are environment dependend.

@siegfriedpammer siegfriedpammer merged commit dd04564 into icsharpcode:master Aug 21, 2024
5 checks passed
@siegfriedpammer
Copy link
Member

Thank you for your contribution!

@Herrmel Herrmel deleted the ignore_empty_dotnetcore_version_path branch August 21, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants