Make Tests Great Again #3231
Merged
Make Tests Great Again #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ARM64 works |
… with ConfigurationBuilder)
| @@ -43,14 +50,16 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="DiffLib" /> | |||
| <PackageReference Include="CliWrap" /> | |||
| <PackageReference Include="Microsoft.Extensions.Configuration" /> | |||
There was a problem hiding this comment.
Two new nuget deps for reading a JSON file?
There was a problem hiding this comment.
Yes, for reading it like a proper settings file. The intent was to be able to later extend it if necessary.
| /// "TestsAssemblyTempPath": "d:\\test\\" | ||
| /// } | ||
| /// </summary> | ||
| internal static class TestsAssemblyOutput |
There was a problem hiding this comment.
Why not simply make this part of the Tester class?
There was a problem hiding this comment.
I am not really partial about the location, it kind of felt like easier not polluting Tester with another concern that is config-driven.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still specialized runners (RoundtripAssembly) or CompileCSharp with null outputfile parameter that will dump assemblies in other places.