Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2757: Inject ILSpyUpdateAssemblyInfo into GetPackageVersionDependsOn #2769

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ICSharpCode.Decompiler/ICSharpCode.Decompiler.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
<DebugSymbols>true</DebugSymbols>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<CodeAnalysisRuleSet>ICSharpCode.Decompiler.ruleset</CodeAnalysisRuleSet>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>

<ItemGroup>
Expand All @@ -57,9 +59,13 @@
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>

<!-- Inject ILSpyUpdateAssemblyInfo as dependency of the GetPackageVersion
target so Pack uses the generated version when evaluating project references. -->
<PropertyGroup>
<CodeAnalysisRuleSet>ICSharpCode.Decompiler.ruleset</CodeAnalysisRuleSet>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<GetPackageVersionDependsOn>
ILSpyUpdateAssemblyInfo;
$(GetPackageVersionDependsOn)
</GetPackageVersionDependsOn>
</PropertyGroup>

<Import Project="..\packages.props" />
Expand Down
9 changes: 9 additions & 0 deletions ICSharpCode.ILSpyX/ICSharpCode.ILSpyX.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,15 @@
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>

<!-- Inject ILSpyUpdateAssemblyInfo as dependency of the GetPackageVersion
target so Pack uses the generated version when evaluating project references. -->
<PropertyGroup>
<GetPackageVersionDependsOn>
ILSpyUpdateAssemblyInfo;
$(GetPackageVersionDependsOn)
</GetPackageVersionDependsOn>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="System.IO.Compression" Version="4.3.0" />
<PackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataVersion)" />
Expand Down