Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Assembly node menu #1

Merged
6 commits merged into from
Feb 10, 2011
Merged

Remove Assembly node menu #1

6 commits merged into from
Feb 10, 2011

Conversation

eusebiu
Copy link
Contributor

@eusebiu eusebiu commented Feb 8, 2011

Just to make sure that you agree with this.

@dgrunwald
Copy link
Member

I don't think there's a need to cache the context menu; can you just return a new one from GetContextMenu()? That makes the code simpler (and more concentrated in one location).

@dgrunwald
Copy link
Member

Sorry, but storing a context menu per tree node is not an option. Tree nodes are supposed to be light-weight (there can be many thousands of them in memory!), they shouldn't reference any WPF objects.
Creating context menus on demand (on right click) works fine in SharpDevelop (it's used in many places), so if it doesn't work with SharpTreeView, that's a bug that needs fixing.

pgourlain pushed a commit to pgourlain/ILSpy that referenced this pull request Apr 15, 2014
siegfriedpammer pushed a commit that referenced this pull request Sep 28, 2017
siegfriedpammer pushed a commit that referenced this pull request Dec 21, 2018
Update UniversalAssemblyResolver to include missing .NET 3 support
siegfriedpammer pushed a commit that referenced this pull request Jun 24, 2020
siegfriedpammer pushed a commit that referenced this pull request Aug 8, 2020
Discussion about the translations
riQQ pushed a commit to riQQ/ILSpy that referenced this pull request Mar 23, 2021
Fixed decompiler exception which is thrown in case there are referenc…
siegfriedpammer pushed a commit that referenced this pull request Sep 9, 2023
siegfriedpammer added a commit that referenced this pull request Aug 20, 2024
WPF Refactoring #1: Add abstraction layer for MEF
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants