Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILSpy generates worse code with NullableAttribute #3233

Closed
CreateAndInject opened this issue Jul 14, 2024 · 0 comments
Closed

ILSpy generates worse code with NullableAttribute #3233

CreateAndInject opened this issue Jul 14, 2024 · 0 comments
Labels
Bug Decompiler The decompiler engine itself

Comments

@CreateAndInject
Copy link
Contributor

test.zip
Class37.method_28
image

When I restored names:
wpacsvr.models.Attribute2 => System.Runtime.CompilerServices.NullableAttribute
wpacsvr.models.Attribute3 => System.Runtime.CompilerServices.NullableContextAttribute

Nullable.zip
image

@siegfriedpammer Can you check if it's the same issue as #3232
@CreateAndInject CreateAndInject added Bug Decompiler The decompiler engine itself labels Jul 14, 2024
@christophwille christophwille mentioned this issue Jul 22, 2024
Closed
mattsh247 pushed a commit to mattsh247/ILSpy that referenced this issue Jul 30, 2024
@siegfriedpammer
TransformDisplayClassUsage: Fix icsharpcode#3233 by ignoring nullabil…
22e2332 
…ity annotations, when trying to find a variable to reuse/propagate.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Decompiler The decompiler engine itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CreateAndInject