fix(BacktraceLine.tsx): handle case where fileUrl is null or undefine…

…d by rendering a span instead of a link fix(gitProvider.ts): return empty string instead of '#' when url is not defined in default case of switch statement
icoretech · May 29, 2023 · 3ddbef7 · 3ddbef7
1 parent 6a0c833
commit 3ddbef7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/components/occurrence/BacktraceLine.tsx b/components/occurrence/BacktraceLine.tsx
@@ -6,10 +6,12 @@ export default function LinkedBacktraceLine({ file, line, project }: { file: str
     const filePath = file.replace('/PROJECT_ROOT/', '');
     const fileUrl = composeFileUrl(project, filePath, line);
 
-    return (
+    return fileUrl ? (
       <a href={fileUrl} target="_blank" rel="noopener noreferrer" className="text-indigo-400 hover:text-indigo-200">
         {file}
       </a>
+    ) : (
+      <span className="text-indigo-400">{file}</span>
     );
   } else {
     return <>{file}</>;

diff --git a/lib/gitProvider.ts b/lib/gitProvider.ts
@@ -8,6 +8,9 @@ export function composeFileUrl(
   const repoUrl = project.repo_url?.toLowerCase() || '';
   const repoBranch = project.repo_branch?.toLowerCase() || '';
   const filePathLower = filePath.toLowerCase();
+  if (!repoUrl || !repoBranch || !filePathLower) {
+    return '';
+  }
 
   let url: string;
 
@@ -55,7 +58,7 @@ export function composeFileUrl(
       }
       break;
     default:
-      url = '#';
+      url = '';
       break;
   }