Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: javascore audit issues #862

Merged
merged 2 commits into from
May 15, 2024
Merged

fix: javascore audit issues #862

merged 2 commits into from
May 15, 2024

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented May 9, 2024 •
edited
Loading

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@ibrizsabin ibrizsabin requested a review from bcsainju May 9, 2024 04:28
@ibrizsabin ibrizsabin added the Audit Issue Issues discovered in security audit label May 9, 2024
@ibrizsabin ibrizsabin self-assigned this May 9, 2024
@ibrizsabin ibrizsabin added the bug Something isn't working label May 9, 2024
@ibrizsabin ibrizsabin merged commit 29f4ad7 into feature/wasm-lightclient-ibc-changes May 15, 2024
5 of 6 checks passed
@ibrizsabin ibrizsabin deleted the fix/javascore-audit-issues branch May 15, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izyak izyak izyak approved these changes

@bcsainju bcsainju bcsainju approved these changes

@AntonAndell AntonAndell Awaiting requested review from AntonAndell AntonAndell is a code owner

@nightowl121 nightowl121 Awaiting requested review from nightowl121 nightowl121 is a code owner

Assignees

@ibrizsabin ibrizsabin

Labels
Audit Issue Issues discovered in security audit bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibrizsabin @izyak @bcsainju