Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

807 add client specific hashing on ack and packet data #825

Merged
merged 2 commits into from
Feb 12, 2024
Merged

807 add client specific hashing on ack and packet data #825

merged 2 commits into from
Feb 12, 2024

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Jan 17, 2024 •
edited
Loading

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@AntonAndell AntonAndell changed the base branch from main to 805-create-ics-08-compatible-tendermint-lightclient-in-java January 17, 2024 11:41
@AntonAndell AntonAndell force-pushed the 807-add-client-specific-hashing-on-ack-and-packet-data branch from 7792d4f to 9f0c64b Compare January 19, 2024 05:13
@AntonAndell AntonAndell linked an issue Feb 8, 2024 that may be closed by this pull request
Add client specific hashing on ack and packet data #807
Open
@AntonAndell AntonAndell force-pushed the 807-add-client-specific-hashing-on-ack-and-packet-data branch from 9f0c64b to dc07e0d Compare February 12, 2024 10:42
@AntonAndell AntonAndell force-pushed the 807-add-client-specific-hashing-on-ack-and-packet-data branch from dc07e0d to 7d0585a Compare February 12, 2024 10:42
@AntonAndell AntonAndell marked this pull request as ready for review February 12, 2024 10:43
@AntonAndell @izyak
feat: add IBC prefix for ics-08 clients and bugfixes (#826)
a7af666 
* feat: Add revision number to light client heights

Add revision number but for now do not add support for resseting chain height

* revert to using two clients

* feat: add IBC prefix for ics-08 clients and bugfixes

* fix: hash ack value before sending to verify membership for ics8 client

---------

Co-authored-by: izyak <lbackup887@gmail.com>
@AntonAndell AntonAndell merged commit a442d95 into 805-create-ics-08-compatible-tendermint-lightclient-in-java Feb 12, 2024
3 of 5 checks passed
@AntonAndell AntonAndell deleted the 807-add-client-specific-hashing-on-ack-and-packet-data branch February 12, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redlarva redlarva Awaiting requested review from redlarva

@ibrizsabin ibrizsabin Awaiting requested review from ibrizsabin

@nightowl121 nightowl121 Awaiting requested review from nightowl121

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add client specific hashing on ack and packet data
1 participant
@AntonAndell