Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer works after last update #1189

Closed
1 task done
adamparr opened this issue Jun 29, 2018 · 5 comments
Closed
1 task done

No longer works after last update #1189

adamparr opened this issue Jun 29, 2018 · 5 comments

Comments

@adamparr
Copy link

adamparr commented Jun 29, 2018

Prerequisites

Description

Uncaught Error: Unexpected packet before version
events.js:183

Error thrown after most recent update to this package. Updated Atom as well with same result.
It is shown when I try connect, everytime.

Steps to Reproduce

  1. Trying to connect to FTP via CMD + S or packages > remote-ftp > connect.

Expected behavior: [What you expect to happen]

It to connect

Actual behavior: [What actually happens]

Error thrown described abouve

Reproduces how often: [What percentage of the time does it reproduce?]

100%

Versions

Currently on Atom version 1.28.0.
macOS High Sierra 10.13.5

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

@icetee
Copy link
Owner

icetee commented Jun 29, 2018

Please paste full error message from console. FTP or SFTP protocol?

@adamparr
Copy link
Author

Atom: 1.28.0 x64
Electron: 2.0.3
OS: Mac OS X 10.13.5
Thrown From: remote-ftp package 2.2.0

Stack Trace

Uncaught Error: Unexpected packet before version

At events.js:183

Error: Unexpected packet before version
    at SFTPStream._transform (/packages/remote-ftp/node_modules/ssh2-streams/lib/sftp.js:304:27)
    at SFTPStream.Transform._read (_stream_transform.js:186:10)
    at SFTPStream._read (/packages/remote-ftp/node_modules/ssh2-streams/lib/sftp.js:181:15)
    at SFTPStream.Transform._write (_stream_transform.js:174:12)
    at doWrite (_stream_writable.js:387:12)
    at writeOrBuffer (_stream_writable.js:373:5)
    at SFTPStream.Writable.write (_stream_writable.js:290:11)
    at Channel.ondata (_stream_readable.js:639:20)
    at emitOne (events.js:116:13)
    at Channel.emit (events.js:211:7)
    at Channel.Readable.read (_stream_readable.js:475:10)
    at flow (_stream_readable.js:846:34)
    at resume_ (_stream_readable.js:828:3)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Commands

     -0:21 window:toggle-dev-tools (atom-notification.fatal.icon.icon-bug.native-key-bindings.has-detail.has-close.has-stack)

Non-Core Packages

atom-beautify 0.32.5 
atom-material-syntax 1.0.8 
atom-material-syntax-dark 1.0.0 
atom-material-ui 2.1.3 
file-icons 2.1.21 
fold-lines 0.2.2 
fonts 3.1.0 
goto-definition 1.3.4 
highlight-selected 0.13.1 
minimap 4.29.8 
minimap-find-and-replace 4.5.2 
minimap-highlight-selected 4.6.1 
minimap-pigments 0.2.2 
nucleus-dark-ui 0.12.3 
php-cs-fixer 4.1.1 
pigments 0.40.2 
remote-ftp 2.2.0 

using SFTP

@icetee
Copy link
Owner

icetee commented Jun 29, 2018

The remote-ftp uses https://github.com/mscdex/ssh2. I think is not this package issue. We can try to refresh it, but I think the bug is still alive.

There are several packages that are affected by this:
yongkangchen/remote-sync#460
liximomo/vscode-sftp#202

You can back to any previous version

apm remove remote-ftp
apm install remote-ftp@2.1.4

(The last upgrade SSH2 and SSH2-streams in v1.3.4)

icetee added a commit that referenced this issue Jun 29, 2018
@icetee
Copy link
Owner

icetee commented Jun 29, 2018

Did I upgrade to let you test it?

apm remove remote-ftp
cd ~
git clone https://github.com/icetee/remote-ftp
cd remote-ftp
git checkout develop
apm install
apm link .

@adamparr
Copy link
Author

Fixed! Not sure what happened. Think the refresh fixed it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants