Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix black linter failures with action update #501

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

JessicaS11
Copy link
Member

@JessicaS11 JessicaS11 commented Jan 26, 2024

Checks that passed yesterday are failing today even without changes to the files causing the failures. Specifically, running black locally results in no reformatting, but then the linting action fails. Likely related to psf/black#4173 and the update of the action to v24.1.0. This PR manually fixes the newline issues causing the linting check failures.

Copy link

github-actions bot commented Jan 26, 2024

Binder 👈 Launch a binder notebook on this branch for commit eead686

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit c626163

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d89fb4b) 66.09% compared to head (c626163) 66.06%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #501      +/-   ##
===============================================
- Coverage        66.09%   66.06%   -0.04%     
===============================================
  Files               36       36              
  Lines             3115     3112       -3     
  Branches           552      552              
===============================================
- Hits              2059     2056       -3     
  Misses             963      963              
  Partials            93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessicaS11 JessicaS11 merged commit 6c187bd into development Jan 26, 2024
6 checks passed
@JessicaS11 JessicaS11 deleted the lint-fails branch January 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant