Minor clean-up #45
Merged
Minor clean-up #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah the life of only having nightly installed on this desktop has gotten the best of me; |
hecrj
requested changes
Nov 7, 2019
memoryruins
force-pushed
the
smol-changes
branch
from
2f51952 to
786ac31
Compare
memoryruins
commented
Apr 2, 2020
|
|
||
| string | ||
| use std::iter::FromIterator; | ||
| String::from_iter(self.0.iter()) |
There was a problem hiding this comment.
Note to anyone looking in from the changelog: this could have been self.0.iter().collect() :)
micro-refactoring intensifies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR utilizes std's impls for text_input and makes use of
mem::takein the todo example.