Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ctrl+Backspace text field behaviour #249

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Add Ctrl+Backspace text field behaviour #249

merged 1 commit into from
Mar 31, 2020

Conversation

michael-swan
Copy link
Contributor

Self explanatory.

@michael-swan
Copy link
Contributor Author

Oh one minor mistake, I should probably make it select to the beginning from the current cursor, not select all in the private case.

@michael-swan
Copy link
Contributor Author

Unless there is a selection of any text (secure or not), in which case Ctrl+Backspace should perform the same function as backspace.

@michael-swan
Copy link
Contributor Author

It should now be all set. @hecrj

@hecrj hecrj added the improvement An internal improvement label Mar 31, 2020
@hecrj hecrj added this to the 0.1.0 milestone Mar 31, 2020
hecrj
hecrj approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! Thank you 🎉

@hecrj hecrj merged commit 3bf938f into iced-rs:master Mar 31, 2020
@hecrj hecrj mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
improvement An internal improvement
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-swan @hecrj