Add disabled state to toggler widget
#2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ght-hunter
approved these changes
Jul 6, 2024
Co-authored-by: Your Name here only <krishnsundaram@gmail.com>
hecrj
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Thanks!
Instead of a disabled method, I have introduced on_toggle and on_toggle_maybe which makes the widget work like button and text_input; for consistency.
Additionally, I have created a label method as well. This removes the awkward Some in the toggler helper.
hecrj
changed the title
toggler widget
|
Thanks @hecrj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement
In our pigg app, we encountered a scenario where it was necessary to disable the toggler based on user interactions. This functionality was crucial to ensure better control and flexibility within the app's user interface.
Implementation
To address this need, I implemented the disable feature for the Toggler widget in Iced. When disabled, the toggler prevents any interaction, thereby enhancing the overall user experience by providing more control over the UI components.
I have also incorporated this feature into the Tour example of Iced to showcase its functionality and usage.
Your feedback and suggestions for further improvements are highly appreciated!