Notify scrollable::Viewport changes
#2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Koranir I'm gonna thank you on my behalf because this is good enough for me. Really clever. I've applied to my fork :) |
hecrj
force-pushed
the
on-scroll-patch
branch
from
797a153 to
130e16f
Compare
hecrj
changed the title
on_scroll to be run on operationscrollable::Viewport changes
Co-authored-by: Daniel Yoon <101683475+Koranir@users.noreply.github.com>
hecrj
force-pushed
the
on-scroll-patch
branch
from
130e16f to
716a11c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2437.
Closes #2490.
Due to some inherent limitations, the operation can't access the
on_scrollfunction, and so it sets a flag to be consumed on a later event. A better solution might be to give operations access to a Shell, so a message could be triggered manually, but that might not be necessary in this case.