Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll Transactions #2401

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Scroll Transactions #2401

merged 1 commit into from
Sep 8, 2024

Conversation

Koranir
Copy link
Contributor

@Koranir Koranir commented Apr 24, 2024

Fixes #2381

This PR adds a system to scrollables that keeps scrolling to only one layer at a time, based on the behaviour in Mozilla's Gecko engine, which is more in line with what users expect.

Also adds a nested scrollable in the scrollable example.

@hecrj hecrj force-pushed the scrollable-scrollover branch from 742e0bc to 502c5fd Compare September 8, 2024 14:01
@hecrj hecrj added this to the 0.13 milestone Sep 8, 2024
@hecrj hecrj added feature New feature or request widget addition labels Sep 8, 2024
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I simplified some stuff here and there. Also, the visible_bounds example already features nested scrollables, so we can use that for testing.

@hecrj hecrj enabled auto-merge September 8, 2024 14:02
@hecrj hecrj merged commit c8686c5 into iced-rs:master Sep 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition feature New feature or request widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested scrollable behaviour
2 participants