Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text::Wrapping support #2279

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Add text::Wrapping support #2279

merged 3 commits into from
Sep 4, 2024

Conversation

nrjais
Copy link
Contributor

@nrjais nrjais commented Feb 21, 2024

This exposes wrapping strategy for text widget. I have kept the default to Wrapping::Word which it was in cosmic_text,
There are other widgets which are using text, I am not sure if Wrapping should be exposed there.

Sample
image

core/src/text.rs Outdated Show resolved Hide resolved
core/src/widget/text.rs Outdated Show resolved Hide resolved
@hecrj hecrj added this to the 0.13 milestone Feb 22, 2024
@nrjais nrjais requested a review from hecrj February 22, 2024 08:37
@nrjais nrjais force-pushed the wrapping branch 2 times, most recently from e40da33 to 6126b70 Compare February 27, 2024 11:11
@habics
Copy link

habics commented Feb 27, 2024

Hi, will this be available for TextEditor widget too or only for Text widget #2291

@habics
Copy link

habics commented Feb 27, 2024

Please consider adding this feature to TextEditor widget too

@nrjais
Copy link
Contributor Author

nrjais commented Feb 27, 2024

Added for text editor also

@nrjais nrjais force-pushed the wrapping branch 2 times, most recently from 139c9b8 to 48c19c9 Compare March 8, 2024 16:19
@nrjais
Copy link
Contributor Author

nrjais commented Mar 9, 2024

Rebased for latest theme changes

@nrjais nrjais force-pushed the wrapping branch 3 times, most recently from 20bd75a to 8ee7a6b Compare April 19, 2024 08:27
@nrjais nrjais force-pushed the wrapping branch 3 times, most recently from 6331fcd to 658f2a5 Compare April 26, 2024 06:05
@nrjais nrjais force-pushed the wrapping branch 2 times, most recently from b27ac1f to 67b992b Compare May 3, 2024 10:15
@nrjais nrjais force-pushed the wrapping branch 2 times, most recently from b7da3bd to 139c390 Compare May 31, 2024 15:43
@nrjais nrjais force-pushed the wrapping branch 2 times, most recently from c300f14 to fe849e2 Compare July 19, 2024 13:27
@hecrj hecrj changed the title Add wrapping strategy to text widget Add text::Wrapping support Sep 4, 2024
Co-authored-by: Neeraj Jaiswal <neerajj85@gmail.com>
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@hecrj hecrj enabled auto-merge September 4, 2024 19:30
@hecrj hecrj merged commit 6009420 into iced-rs:master Sep 4, 2024
12 checks passed
@nrjais nrjais deleted the wrapping branch September 4, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants