Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize Checkbox #192

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Customize Checkbox #192

merged 2 commits into from
Feb 18, 2020

Conversation

clarkmoody
Copy link
Contributor

Add size, spacing, and text_size properties to Checkbox.

clarkmoody
clarkmoody commented Feb 17, 2020
View reviewed changes
native/src/widget/checkbox.rs Outdated
Comment on lines 59 to 62
size: 20,
width: Length::Shrink,
spacing: 15,
text_size: 20,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be really nice to pull these from an underlying renderer.

Copy link
Member

@hecrj hecrj Feb 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we can add these to the Renderer trait using associated constants.

@hecrj hecrj added the feature New feature or request label Feb 18, 2020
@hecrj hecrj added this to the 0.1.0 milestone Feb 18, 2020
hecrj
hecrj approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I have moved the constants to checkbox::Renderer and did something similar with text::Renderer so we can reuse the default text size instead of redefining it.

I think we can merge this. Let me know.

@clarkmoody
Copy link
Contributor Author

clarkmoody commented Feb 18, 2020 via email

@hecrj hecrj merged commit 80fc8c2 into iced-rs:master Feb 18, 2020
@clarkmoody clarkmoody deleted the checkbox-settings branch February 18, 2020 16:07
@hecrj hecrj mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@clarkmoody @hecrj