Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Make gradient pack fn public for iced_graphics::Gradient #1871

Merged
merged 4 commits into from
May 29, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions graphics/src/gradient.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ impl From<Linear> for Gradient {
}
}

impl Gradient {
/// Packs the [`Gradient`] for use in shader code.
pub fn pack(&self) -> Packed {
match self {
Gradient::Linear(linear) => linear.pack(),
}
}
}

/// A linear gradient that can be used in the style of [`Fill`] or [`Stroke`].
///
/// [`Fill`]: crate::geometry::Fill;
Expand Down Expand Up @@ -85,4 +94,35 @@ impl Linear {

self
}

/// Packs the [`Gradient`] for use in shader code.
pub fn pack(&self) -> Packed {
let mut data: [f32; 44] = [0.0; 44];

for (index, stop) in self.stops.iter().enumerate() {
let [r, g, b, a] =
stop.map_or(Color::default(), |s| s.color).into_linear();

data[index * 4] = r;
data[(index * 4) + 1] = g;
data[(index * 4) + 2] = b;
data[(index * 4) + 3] = a;

data[32 + index] = stop.map_or(2.0, |s| s.offset);
}

data[40] = self.start.x;
data[41] = self.start.y;
data[42] = self.end.x;
data[43] = self.end.y;

Packed { data }
}
}

/// Packed [`Gradient`] data for use in shader code.
#[derive(Debug)]
pub struct Packed {
/// The packed [`Gradient`] data.
pub data: [f32; 44],
hecrj marked this conversation as resolved.
Show resolved Hide resolved
}
50 changes: 6 additions & 44 deletions wgpu/src/geometry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ use crate::graphics::geometry::{
use crate::graphics::primitive::{self, Primitive};
use crate::graphics::Gradient;

use iced_graphics::gradient;
use lyon::geom::euclid;
use lyon::tessellation;
use std::borrow::Cow;
Expand Down Expand Up @@ -74,7 +75,7 @@ impl BufferStack {
Box::new(tessellation::BuffersBuilder::new(
buffer,
GradientVertex2DBuilder {
gradient: pack_gradient(gradient),
gradient: gradient.pack(),
},
))
}
Expand All @@ -97,7 +98,7 @@ impl BufferStack {
Box::new(tessellation::BuffersBuilder::new(
buffer,
GradientVertex2DBuilder {
gradient: pack_gradient(gradient),
gradient: gradient.pack(),
},
))
}
Expand Down Expand Up @@ -490,7 +491,7 @@ impl Frame {
}

struct GradientVertex2DBuilder {
gradient: [f32; 44],
gradient: gradient::Packed,
}

impl tessellation::FillVertexConstructor<primitive::GradientVertex2D>
Expand All @@ -504,7 +505,7 @@ impl tessellation::FillVertexConstructor<primitive::GradientVertex2D>

primitive::GradientVertex2D {
position: [position.x, position.y],
gradient: self.gradient,
gradient: self.gradient.data,
}
}
}
Expand All @@ -520,7 +521,7 @@ impl tessellation::StrokeVertexConstructor<primitive::GradientVertex2D>

primitive::GradientVertex2D {
position: [position.x, position.y],
gradient: self.gradient,
gradient: self.gradient.data,
}
}
}
Expand Down Expand Up @@ -623,42 +624,3 @@ pub(super) fn dashed(path: &Path, line_dash: LineDash<'_>) -> Path {
);
})
}

/// Packs the [`Gradient`] for use in shader code.
fn pack_gradient(gradient: &Gradient) -> [f32; 44] {
match gradient {
Gradient::Linear(linear) => {
let mut pack: [f32; 44] = [0.0; 44];
let mut offsets: [f32; 8] = [2.0; 8];

for (index, stop) in linear.stops.iter().enumerate() {
let [r, g, b, a] = stop
.map_or(crate::core::Color::default(), |s| s.color)
.into_linear();

pack[index * 4] = r;
pack[(index * 4) + 1] = g;
pack[(index * 4) + 2] = b;
pack[(index * 4) + 3] = a;

offsets[index] = stop.map_or(2.0, |s| s.offset);
}

pack[32] = offsets[0];
pack[33] = offsets[1];
pack[34] = offsets[2];
pack[35] = offsets[3];
pack[36] = offsets[4];
pack[37] = offsets[5];
pack[38] = offsets[6];
pack[39] = offsets[7];

pack[40] = linear.start.x;
pack[41] = linear.start.y;
pack[42] = linear.end.x;
pack[43] = linear.end.y;

pack
}
}
}