Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node::move_to and make Node::align public #187

Merged
merged 7 commits into from
Feb 14, 2020
Merged

Add Node::move_to and make Node::align public #187

merged 7 commits into from
Feb 14, 2020

Conversation

daxpedda
Copy link
Contributor

To help create custom widgets.

@daxpedda daxpedda mentioned this pull request Feb 14, 2020
Closed
hecrj
hecrj requested changes Feb 14, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I left a comment that we should address before merging. Let me know what you think.

native/src/layout/node.rs Show resolved Hide resolved
@hecrj hecrj added the feature New feature or request label Feb 14, 2020
@hecrj hecrj added this to the 0.1.0 milestone Feb 14, 2020
@hecrj hecrj changed the title Extend public interface of Node. Add Node::move_to and make Node::align public Feb 14, 2020
hecrj
hecrj approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merging as soon as CI gives us the green light. Thanks! 🥂

@daxpedda
Copy link
Contributor Author

Thanks, the documentation is much better!

@hecrj hecrj merged commit cf53026 into iced-rs:master Feb 14, 2020
@hecrj hecrj mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@daxpedda @hecrj