Skip to content

Commit

Permalink
chore: deprecation in v1.5 comments (argoproj#1109)
Browse files Browse the repository at this point in the history
* chore: deprecate in v1.5 comments

Signed-off-by: Derek Wang <whynowy@gmail.com>
  • Loading branch information
whynowy authored Mar 12, 2021
1 parent 2e04546 commit 970d355
Show file tree
Hide file tree
Showing 14 changed files with 64 additions and 60 deletions.
4 changes: 2 additions & 2 deletions api/event-source.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions api/event-source.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions api/openapi-spec/swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions api/sensor.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 12 additions & 10 deletions api/sensor.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions pkg/apis/common/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,13 @@ type TLSConfig struct {
ClientKeySecret *corev1.SecretKeySelector `json:"clientKeySecret,omitempty" protobuf:"bytes,3,opt,name=clientKeySecret"`

// DeprecatedCACertPath refers the file path that contains the CA cert.
// Deprecated: use CACertSecret instead
// Deprecated: will be removed in v1.5, use CACertSecret instead
DeprecatedCACertPath string `json:"caCertPath,omitempty" protobuf:"bytes,4,opt,name=caCertPath"`
// DeprecatedClientCertPath refers the file path that contains client cert.
// Deprecated: use ClientCertSecret instead
// Deprecated: will be removed in v1.5, use ClientCertSecret instead
DeprecatedClientCertPath string `json:"clientCertPath,omitempty" protobuf:"bytes,5,opt,name=clientCertPath"`
// DeprecatedClientKeyPath refers the file path that contains client key.
// Deprecated: use ClientKeySecret instead
// Deprecated: will be removed in v1.5, use ClientKeySecret instead
DeprecatedClientKeyPath string `json:"clientKeyPath,omitempty" protobuf:"bytes,6,opt,name=clientKeyPath"`
}

Expand Down
6 changes: 3 additions & 3 deletions pkg/apis/common/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions pkg/apis/common/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/apis/eventsource/v1alpha1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/apis/eventsource/v1alpha1/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/apis/eventsource/v1alpha1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ type CalendarEventSource struct {
Timezone string `json:"timezone,omitempty" protobuf:"bytes,4,opt,name=timezone"`
// UserPayload will be sent to sensor as extra data once the event is triggered
// +optional
// Deprecated. Please use Metadata instead.
// Deprecated: will be removed in v1.5. Please use Metadata instead.
UserPayload json.RawMessage `json:"userPayload,omitempty" protobuf:"bytes,5,opt,name=userPayload,casttype=encoding/json.RawMessage"`
// Metadata holds the user defined metadata which will passed along the event payload.
// +optional
Expand Down Expand Up @@ -625,7 +625,7 @@ type PubSubEventSource struct {
// +optional
JSONBody bool `json:"jsonBody,omitempty" protobuf:"varint,7,opt,name=jsonBody"`
// CredentialsFile is the file that contains credentials to authenticate for GCP
// Deprecated, use CredentialSecret instead
// Deprecated: will be removed in v1.5, use CredentialSecret instead
DeprecatedCredentialsFile string `json:"credentialsFile" protobuf:"bytes,8,opt,name=credentialsFile"`
// Metadata holds the user defined metadata which will passed along the event payload.
// +optional
Expand Down
Loading

0 comments on commit 970d355

Please sign in to comment.