This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
refactor: app provider #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wssgcg1213
previously approved these changes
Oct 31, 2022
answershuto
previously approved these changes
Oct 31, 2022
chenjun1011
reviewed
Oct 31, 2022
| </AppDataProvider> | ||
| </AppContextProvider> | ||
| <AppDataProvider value={appData}> | ||
| <AppProvider> |
There was a problem hiding this comment.
有没有觉得 AppProvider 插在这里看着有点语义不太明确，不知道是做什么的。其他的 AppDataProvider、 AppContextProvider 对比起来，一看就知道是提供了 app 的 data 和 context
There was a problem hiding this comment.
AppProvider -> AppRuntimeProvider
chenjun1011
previously approved these changes
Oct 31, 2022
luhc228
dismissed stale reviews from chenjun1011, answershuto, and wssgcg1213
via
d32f714
ClarkXia
reviewed
Nov 2, 2022
ClarkXia
reviewed
Nov 2, 2022
| </AppContextProvider> | ||
| <AppDataProvider value={appData}> | ||
| <AppRuntimeProvider> | ||
| <AppContextProvider value={appContext}> |
There was a problem hiding this comment.
这个顺序建议调整为 Context > Data > Runtime
There was a problem hiding this comment.
runClientApp 中路由切换时候要把 appContext 的值更新到最新的
chenjun1011
approved these changes
Nov 2, 2022
ClarkXia
approved these changes
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #607