This repository was archived by the owner on Nov 17, 2022. It is now read-only.
feat: ClientOnly component #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
记录下代码移除的问题 |
ClarkXia
reviewed
Sep 21, 2022
chenjun1011
reviewed
Sep 23, 2022
chenjun1011
reviewed
Oct 11, 2022
ClarkXia
reviewed
Oct 14, 2022
wssgcg1213
previously approved these changes
Oct 14, 2022
wssgcg1213
reviewed
Oct 17, 2022
| if (mounted) { | ||
| if ( | ||
| typeof children !== 'function' && | ||
| process.env.NODE_ENV === 'development' |
There was a problem hiding this comment.
像这种 DEV 阶段的判断, 能不能统一成内部定义的方式, 而不是像 process.env.NODE_ENV === 'development' 这样的由 Node.js 习惯衍生而来的判断方式
wssgcg1213
approved these changes
Oct 17, 2022
chenjun1011
approved these changes
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #460 (comment)