Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

refactor: generate data-loader only by getData #514

Merged
merged 7 commits into from
Sep 22, 2022

Conversation

chenjun1011
Copy link
Contributor

@chenjun1011 chenjun1011 commented Sep 8, 2022

fix #513

增加 dataLoader 配置,用于关闭 data loader 脚本的生成

@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ice-v3 ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 11:05AM (UTC)

@luhc228 luhc228 changed the base branch from release-next to chore/remove-consola-from-runtime September 8, 2022 03:49
@codecov-commenter
Copy link

Codecov Report

Base: 82.12% // Head: 88.32% // Increases project coverage by +6.19% 🎉

Coverage data is based on head (29a9745) compared to base (5d10f02).
Patch coverage: 95.20% of modified lines in pull request are covered.

Additional details and impacted files
@@                          Coverage Diff                          @@
##           chore/remove-consola-from-runtime     #514      +/-   ##
=====================================================================
+ Coverage                              82.12%   88.32%   +6.19%     
=====================================================================
  Files                                     90      109      +19     
  Lines                                   7669     9445    +1776     
  Branches                                 971     1298     +327     
=====================================================================
+ Hits                                    6298     8342    +2044     
+ Misses                                  1364     1095     -269     
- Partials                                   7        8       +1     
Impacted Files Coverage Δ
packages/plugin-rax-compat/src/index.ts 70.40% <0.00%> (ø)
packages/ice/src/config.ts 77.57% <33.33%> (+1.99%) ⬆️
packages/runtime/src/Document.tsx 82.08% <33.33%> (ø)
packages/rax-compat/src/intersection-observer.ts 79.44% <42.85%> (ø)
packages/ice/src/createService.ts 95.12% <93.33%> (+0.27%) ⬆️
packages/ice/src/esbuild/cssModules.ts 88.34% <100.00%> (+19.49%) ⬆️
packages/ice/src/esbuild/transformPipe.ts 78.34% <100.00%> (+3.83%) ⬆️
packages/ice/src/service/runtimeGenerator.ts 83.75% <100.00%> (ø)
packages/ice/src/tasks/web/index.ts 100.00% <100.00%> (ø)
packages/ice/src/utils/renderExportsTemplate.ts 92.10% <100.00%> (ø)
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luhc228 luhc228 changed the base branch from chore/remove-consola-from-runtime to release-next September 8, 2022 04:04
@luhc228 luhc228 changed the base branch from release-next to chore/remove-consola-from-runtime September 8, 2022 04:04
@ClarkXia
Copy link
Collaborator

ClarkXia commented Sep 8, 2022

更倾向于增加配置项,现阶段 data-loader 还存在重复打包 request 等库的问题。现在的处理会导致 getAppData 依赖 getData 的写法而表现不一致。

Base automatically changed from chore/remove-consola-from-runtime to release-next September 15, 2022 03:34
@chenjun1011 chenjun1011 merged commit dc2bd1c into release-next Sep 22, 2022
@chenjun1011 chenjun1011 deleted the fix-data-loader branch September 22, 2022 07:56
@ClarkXia ClarkXia mentioned this pull request Sep 22, 2022
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants