Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outdated .net framework prevents test execution on apple silicon #548

Closed
wants to merge 2 commits into from
Closed

fix: outdated .net framework prevents test execution on apple silicon #548

wants to merge 2 commits into from

Conversation

Meerownymous
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • I made sure that my code builds
  • I merged the master into this branch before pushing
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?** (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Cannot test on apple silicon machine

What is the new behavior?

closes #546

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications

Other information

Updated to .Net7.0 which needs to be present on contributors machines.

@MSE1188
Copy link
Contributor

MSE1188 commented Oct 5, 2023

The CI is failing, because the environment variables cannot be read, probably because of your fork. I added a flag to only validating the variables on release. Please merge main here

…nto i564-update-testproject-netframework
@Meerownymous
Copy link
Collaborator Author

done

@MSE1188
Copy link
Contributor

MSE1188 commented Oct 5, 2023

closed via #550

@MSE1188 MSE1188 closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated .Net framework prevents test execution on Apple Silicon
2 participants