"Fix" invisible projects #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pagination for project fetch for the header is hardcoded to 10 and doesn't iterate over pages. This also indicates an issue with the controller implementation, because when filtering you still have invisble projects, because it will apply title filters *after* the page limit is applied. Confirmed with admin/non-admin setting on an account. Without admin, the user did not have all 10+ projects that exist in RH production instance now, and could see the previously invisible project. This was triggered by having more than 10 projects in production instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pagination for project fetch for the header is hardcoded to 10 and doesn't iterate over pages.
This also indicates an issue with the controller implementation, because when filtering you still have invisble projects, because it will apply title filters after the page limit is applied.
Confirmed with admin/non-admin setting on an account. Without admin, the user did not have all 10+ projects that exist in RH production instance now, and could see the previously invisible project.
This was triggered by having more than 10 projects in production instance.