Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use httpstatus module #505

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Conversation

mshriver
Copy link
Contributor

@mshriver mshriver commented Jun 17, 2024

Use the module imports instead of magic numbers. They probably won't change but some linting/formatting/mypy rules start to enforce it.

These were all the uses of the status codes that I found throughout the backend codebase. There may be some others that are hiding but it's not critical to get 100% of them in this PR.

@mshriver mshriver added the python Pull requests that update Python code label Jun 17, 2024
@mshriver mshriver force-pushed the use-httpstatus-module branch 2 times, most recently from d278f32 to bbd569a Compare June 17, 2024 16:19
@mshriver mshriver marked this pull request as ready for review June 17, 2024 16:19
@mshriver mshriver force-pushed the use-httpstatus-module branch 3 times, most recently from ff2742d to 81f26fe Compare June 17, 2024 16:35
@mshriver mshriver added the good first issue Good for newcomers label Jun 17, 2024
@mshriver mshriver force-pushed the use-httpstatus-module branch from 81f26fe to 8dfb910 Compare June 17, 2024 22:02
@mshriver mshriver force-pushed the use-httpstatus-module branch from 8dfb910 to 2a8eb63 Compare June 17, 2024 22:03
Copy link
Collaborator

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Griffin Sullivan <48397354+Griffin-Sullivan@users.noreply.github.com>
@mshriver mshriver merged commit 6597452 into ibutsu:master Jun 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants