Move to Ruff Formatting and Linting #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
changed the title
mshriver
added
enhancement
mshriver
force-pushed
the
move-to-ruff
branch
2 times, most recently
from
15ad5c0 to
c2f1911
Compare
mshriver
changed the title
mshriver
force-pushed
the
move-to-ruff
branch
2 times, most recently
from
d9ca8e3 to
5498d09
Compare
LightOfHeaven1994
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
LGTM.
Note: I'm thinking that we need to have pinned packages instead of what we are doing now. As we had some issues in the past because packages randomly updated. This is out of scope of this PR, but we will need to do that to ensure that ibutsu will not break on prod because of some random package
mshriver
commented
Jun 10, 2024
mshriver
changed the title
mshriver
force-pushed
the
move-to-ruff
branch
3 times, most recently
from
c3e20b3 to
07bd9e3
Compare
ruff lint/format implementations Update dockerfiles for hadolint standards add 3.11 to github matrix Update podman_build.sh script Track results a bit better, and use printf
LightOfHeaven1994
approved these changes
Jun 11, 2024
mshriver
commented
Jun 11, 2024
Use getopts to implement help text and a flag for images with no registry Move default image tag back to quay.io/ibutsu prefix, use new flag to control it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to ruff and ruff-format, include a few rules to replace previous pre-commit hooks for python.
Introduce hadolint, and adhere to (most) of it's rules.
Remaining work:
Trying to trace some history and purpose of the different image building scripts in the repo.
Handling Python updates and podman/compose/OCP template and script updates in another PR.