Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct check condition on group field #493

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Correct check condition on group field #493

merged 1 commit into from
Apr 18, 2024

Conversation

LightOfHeaven1994
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 commented Apr 8, 2024 •
edited
Loading

I missed here that string_to_column can return you datatype qlalchemy.sql.elements.BinaryExpression that has no boolean value definition. It's more correct to check if variable is None

@LightOfHeaven1994 LightOfHeaven1994 merged commit 5801455 into ibutsu:master Apr 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LightOfHeaven1994