Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft commit for importance widget component #485

Conversation

jjaquish
Copy link
Collaborator

@jjaquish jjaquish commented Mar 5, 2024

DRAFT for a widget to show test results filtered by component and grouped by test importance

@jjaquish jjaquish force-pushed the jjaquish/importance-by-component-widget branch from 7765607 to 657e8c1 Compare March 11, 2024 21:06
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides cleaning up some comments, the code looks good. Haven't tested on my own yet.

backend/ibutsu_server/widgets/importance_component.py Outdated Show resolved Hide resolved
frontend/src/widgets/importancecomponent.js Outdated Show resolved Hide resolved
@jjaquish jjaquish changed the title DRAFT: Initial draft commit for importance widget component Initial draft commit for importance widget component Mar 21, 2024
@jjaquish
Copy link
Collaborator Author

Attached is a video of the widget

Screenshare.-.2024-03-28.12_21_00.PM.mp4

Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, great work! There is only 1 small thing that we can fix before merging it

backend/ibutsu_server/constants.py Outdated Show resolved Hide resolved
@LightOfHeaven1994 LightOfHeaven1994 merged commit bae88c4 into ibutsu:master Apr 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants