Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local dev setup #471

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix local dev setup #471

merged 1 commit into from
Nov 28, 2023

Conversation

LightOfHeaven1994
Copy link
Collaborator

No description provided.

rsnyman
rsnyman reviewed Nov 28, 2023
View reviewed changes
backend/setup.py Outdated Show resolved Hide resolved
rsnyman
rsnyman reviewed Nov 28, 2023
View reviewed changes
docker-compose.dev.yml Outdated Show resolved Hide resolved
@LightOfHeaven1994 LightOfHeaven1994 force-pushed the fix-local-dev-setup branch 2 times, most recently from d162df8 to 19f6253 Compare November 28, 2023 17:35
@LightOfHeaven1994 LightOfHeaven1994 marked this pull request as ready for review November 28, 2023 17:35
@LightOfHeaven1994
Copy link
Collaborator Author

@rsnyman feel free to merge it when you have time

rsnyman
rsnyman requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@rsnyman rsnyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine except the postgres change, which I've commented on.

docker-compose.dev.yml Outdated Show resolved Hide resolved
@rsnyman rsnyman mentioned this pull request Nov 28, 2023
Closed
@LightOfHeaven1994 @rsnyman
Fix local dev setup
bedd246 
- Pin connexion to specific version
- Fix permissions on volume with running docker compose
- Improve docker compose
- Have password set correctly for local dev setup

Co-authored-by: Raoul Snyman <raoul@snyman.info>
@rsnyman rsnyman merged commit 723bd92 into ibutsu:master Nov 28, 2023
9 checks passed
@LightOfHeaven1994 LightOfHeaven1994 mentioned this pull request Dec 5, 2023
Closed
@LightOfHeaven1994 LightOfHeaven1994 mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsnyman rsnyman rsnyman approved these changes

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LightOfHeaven1994 @RonnyPfannschmidt @rsnyman