Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psu-ng: Modified logic to handle MFR warning #26

Open
wants to merge 1 commit into
base: 1060
Choose a base branch
from

Conversation

faisal-awada
Copy link

Modified the logic to handle bit 7 (0x80) in MFR fault. The change include:

  • If MFR specific bit 7 (0x80) is set, log journal message instead of an error. This journal message logged only once during power-on.
  • Reset 12V current share warning (bit 7) and leave the existing logic in place to check for other bits.

Test:

  • On the simulator, set MFR specific word to 0x80 and set the status word to 0x1000. Verified the system logged journal message with no PELs generated.
  • On the simulator, set MFR Specific to 0xC0 and status word to 0x1000. Verified journal message "12V current share warning" was logged, and a PEL was reported with SRC "110015F1"

Change-Id: Iacf02695c2b35e8e054111217dae74653cacdca8

Modified the logic to handle bit 7 (0x80) in MFR fault. The change
include:

- If MFR specific bit 7 (0x80) is set, log journal message instead
  of an error. This journal message logged only once during power-on.
- Reset 12V current share warning (bit 7) and leave the existing logic
  in place to check for other bits.

Test:
  - On the simulator, set MFR specific word to 0x80 and set the status
    word to 0x1000. Verified the system logged journal message with no
    PELs generated.
  - On the simulator, set MFR Specific to 0xC0 and status word to
    0x1000. Verified journal message "12V current share warning" was
    logged, and a PEL was reported with SRC "110015F1"

Change-Id: Iacf02695c2b35e8e054111217dae74653cacdca8
Signed-off-by: Faisal Awada <faisal@us.ibm.com>
Copy link

@derekhoward55 derekhoward55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for these scenarios: IBMCFF psu cs fault, IBMCFF psu other mfr fault, IBMCFF psu cs AND other mfr fault, Bonnell (no mfr setting in status_word), and random non-IBMCFF psu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants