Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalData: Add API for Retrieving Sibling BMC IP #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manish-t-in
Copy link

ExternalData: Add API for Retrieving Sibling BMC IP

  • Introduces a framework to retrieve external dependent data, which can be
    hosted on DBus, Filesystem, or other sources by various applications.

  • Adds an interface to fetch the Sibling BMC IP, which will be used to obtain
    the corresponding BMC IP.

  • External data retrieval happens in parallel during the configuration sync
    phase, ensuring the sync operation starts only after all tasks are completed.

@jenkins-openbmc-ibm
Copy link

Can one of the admins verify this patch?

- Introduces a framework to retrieve external dependent data, which can
  be hosted on DBus, Filesystem, or other sources by various
  applications.

- Adds an interface to fetch the Sibling BMC IP, which will be used to
  obtain the corresponding BMC IP.

- External data retrieval happens in parallel during the configuration
  sync phase, ensuring the sync operation starts only after all tasks
  are completed.

Tested:
- Verified that the Sibling BMC IP is correctly fetched (currently
  hardcoded until Network DBus is hosting it).
- bmc0 output:
  BmcPosition: 0
  siblingBmcIP: 10.2.2.100

- bmc1 output:
  BmcPosition: 1
  siblingBmcIP: 10.0.2.100

Change-Id: Icad7a826b7577e8e85e68cd2ee812961a372cebb
Signed-off-by: Manish Tiwari <tmanish.in@gmail.com>
@spinler
Copy link
Collaborator

spinler commented Jan 10, 2025

From the commit message:

Introduces a framework to retrieve external dependent data, which can
be hosted on DBus, Filesystem, or other sources by various
applications.

This commit didn't introduce that framework, so you can remove that sentence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants