Enable PEL for Bios Handler Class #560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RekhaAparna01
force-pushed
the
pelForBiosHandler
branch
from
5ff3f64 to
7dc81ad
Compare
RekhaAparna01
requested review from
SunnySrivastava1984,
jinuthomas,
PriyangaRamasamy,
souvik1914581 and
branupama
RekhaAparna01
force-pushed
the
pelForBiosHandler
branch
2 times, most recently
from
6c6dcc9 to
9b6fbf0
Compare
RekhaAparna01
force-pushed
the
pelForBiosHandler
branch
from
9b6fbf0 to
b9a047b
Compare
vpd-manager/src/bios_handler.cpp
Outdated
| // TODO: log a predicitive PEL. | ||
| logging::logMessage("Invalid typre received from BIOS table."); | ||
| EventLogger::createSyncPel( | ||
| types::ErrorType::InvalidVpdMessage, |
There was a problem hiding this comment.
Should the type be DbusFailure since there is an invalid type in the D-Bus message received from BIOS Config Manager?
vpd-manager/src/bios_handler.cpp
Outdated
| logging::logMessage( | ||
| "Invalid type read for memory mirror mode value from DBus. Skip writing to VPD"); | ||
| EventLogger::createSyncPel( | ||
| types::ErrorType::InvalidVpdMessage, |
There was a problem hiding this comment.
Should type be DbusFailure here?
This commit adds code to log PEL in BiosHandler class, in case of
exceptions occurred while updating the the BIOS attribute values.
output:
'''
root@p10bmc:/tmp# peltool -i 0x5000254B
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc vpd",
"Created at": "01/15/2025 09:12:41",
"Committed at": "01/15/2025 09:12:41",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x5000254B",
"Entry Id": "0x5000254B",
"BMC Event Log Id": "15"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "bmc error logging",
"Subsystem": "CEC Hardware - VPD Interface",
"Event Scope": "Entire Platform",
"Event Severity": "Informational Event",
"Event Type": "Miscellaneous, Informational Only",
"Action Flags": [
"Event not customer viewable",
"Report Externally"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc vpd",
"SRC Version": "0x02",
"SRC Format": "0x55",
"Virtual Progress SRC": "False",
"I5/OS Service Event Bit": "False",
"Hypervisor Dump Initiated":"False",
"Backplane CCIN": "2E2D",
"Terminate FW Error": "False",
"Deconfigured": "False",
"Guarded": "False",
"Error Details": {
"Message": "A Dbus internal error occurred."
},
"Valid Word Count": "0x09",
"Reference Code": "BD554005",
"Hex Word 2": "00000055",
"Hex Word 3": "2E2D0010",
"Hex Word 4": "00000000",
"Hex Word 5": "00000000",
"Hex Word 6": "00000000",
"Hex Word 7": "00000000",
"Hex Word 8": "00000000",
"Hex Word 9": "00000000",
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this type as a unit",
"Procedure": "BMC0001"
}]
}
},
"Extended User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Reporting Machine Type": " ",
"Reporting Serial Number": " ",
"FW Released Ver": "RB1110_025",
"FW SubSys Version": "fw1110.00-3.53",
"Common Ref Time": "00/00/0000 00:00:00",
"Symptom Id Len": "20",
"Symptom Id": "BD554005_2E2D0010"
},
"Failing MTMS": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Machine Type Model": " ",
"Serial Number": " "
},
"User Data 0": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"BMCLoad": "1.62 1.17 0.89",
"BMCState": "Ready",
"BMCUptime": "0y 0d 0h 56m 29s",
"BootState": "Unspecified",
"ChassisState": "Off",
"FW Version ID": "fw1110.00-3.53-1110.2503.20250109a (RB1110_025)",
"HostState": "Off",
"System IM": "50001001"
},
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"DESCRIPTION": "DBus call to update NVRAM value in pending attribute failed. Test Error",
"FileName": "/usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/src/bios_handler.cpp",
"FunctionName": "saveClearNvramToBios",
"InteranlRc": "0",
"UserData1": "",
"UserData2": ""
}
}
'''
Signed-off-by: RekhaAparna01 <vrekhaaparna@ibm.com>
RekhaAparna01
force-pushed
the
pelForBiosHandler
branch
from
b9a047b to
59195f4
Compare
SunnySrivastava1984
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code to log PEL in BiosHandler class, in case of exceptions occurred while updating the the BIOS attribute values.
output: