Enable write keyword in backup and restore #385
Conversation
branupama
requested review from
jinuthomas,
souvik1914581 and
SunnySrivastava1984
| @@ -157,6 +157,17 @@ void BackupAndRestore::backupAndRestoreIpzVpd(types::IPZVpdMap& io_srcVpdMap, | |||
| return; | |||
| } | |||
|
|
|||
| const std::string l_srcFruPath = | |||
| jsonUtility::getFruPathFromJson(m_sysCfgJsonObj, i_srcPath); | |||
There was a problem hiding this comment.
What will be the flow if these APIs throws? Should caller handle those or this API should handle that and return to the caller or should the json utility handle that and return empty here?
There was a problem hiding this comment.
if backupAndRestoreIpzVpd is completed without exception, at the caller we declaring Backup&Restore is success and also returning the update src & dst vpd map.
Caller is caching the exceptions from backupAndRestore* API's.
I have created the issue (#381) to relook at exceptions handling in backup&restore API's.
There was a problem hiding this comment.
ok, on the basis of the issue, I am marking this comment as closed.
Need to revisit to optimize the exception handling in this class.
src/backup_restore.cpp
Outdated
| /* To keep the data in sync between hardware and parsed map | ||
| updating the io_dstVpdMap. This should only be done if write | ||
| on hardware returns success.*/ | ||
| std::shared_ptr<Parser> l_vpdParser = |
There was a problem hiding this comment.
auto can be used here as well. Also please use a blank line between blocks of code.
branupama
force-pushed
the
enable_write_in_BAR
branch
from
650492d to
d56e0f7
Compare
| @@ -157,6 +157,17 @@ void BackupAndRestore::backupAndRestoreIpzVpd(types::IPZVpdMap& io_srcVpdMap, | |||
| return; | |||
| } | |||
|
|
|||
| const std::string l_srcFruPath = | |||
| jsonUtility::getFruPathFromJson(m_sysCfgJsonObj, i_srcPath); | |||
There was a problem hiding this comment.
ok, on the basis of the issue, I am marking this comment as closed.
Need to revisit to optimize the exception handling in this class.
This commit adds the changes to enable write keyword’s value on hardware in the backup & restore functionality. Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>
branupama
force-pushed
the
enable_write_in_BAR
branch
from
d56e0f7 to
ba94fbb
Compare
This commit adds the changes to enable write keyword’s value on hardware in the backup & restore functionality.