libpldm: Stabilizing pldm_close() #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
please run jenkins CI test |
riyadixitagra
changed the title
|
add to approvelist |
|
can you add a comment that this is a old/deprecated API in the header file libpldm/include/libpldm/requester/pldm.h like its done https://github.com/openbmc/libpldm/blob/1d0e2d4b23ad6880e6122c478fcc77b02681655e/include/libpldm/requester/pldm.h#L31 |
Similar comment is already there. |
riyadixitagra
changed the title
Pavithrab7
approved these changes
Oct 6, 2023
Changing ABI visibility from TESTING to STABLE for a requester API pldm_close() which uses pldm_transport_mctp_demux_destroy(), a transport API whose visibility is also changed likewise. Use of pldm_close is demonstrated here- https://gerrit.openbmc.org/c/openbmc/openpower-occ-control/+/66800 Tested: Error injection did not result in any pldm_send() failure Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>
jaypadath
approved these changes
Oct 6, 2023
manojkiraneda
pushed a commit
to manojkiraneda/libpldm
that referenced
this pull request
Jul 29, 2024
To ensure memmem() is visible _GNU_SOURCE needs to be defined early, at least before any system headers are included. Define it in the build flags as clang-tidy will re-order includes based on vibes rather than dependencies. Finally, clean up the remaining compiler warnings by dropping the unnecessary casts. Note that _GNU_SOURCE implies _DEFAULT_SOURCE, so we drop the latter: > Since glibc 2.19, defining _GNU_SOURCE also has the effect of > implicitly defining _DEFAULT_SOURCE. Before glibc 2.20, defining > _GNU_SOURCE also had the effect of implicitly defining _BSD_SOURCE > and _SVID_SOURCE. https://www.man7.org/linux/man-pages/man7/feature_test_macros.7.html Fixes: ibm-openbmc#12 Fixes: 1523778 ("msgbuf: Add pldm_msgbuf_span_string_utf16()") Change-Id: I9206f7616740790a89366762cce11d3045471b97 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
ArchanaKakani
pushed a commit
to ArchanaKakani/libpldm
that referenced
this pull request
Sep 6, 2024
To ensure memmem() is visible _GNU_SOURCE needs to be defined early, at least before any system headers are included. Define it in the build flags as clang-tidy will re-order includes based on vibes rather than dependencies. Finally, clean up the remaining compiler warnings by dropping the unnecessary casts. Note that _GNU_SOURCE implies _DEFAULT_SOURCE, so we drop the latter: > Since glibc 2.19, defining _GNU_SOURCE also has the effect of > implicitly defining _DEFAULT_SOURCE. Before glibc 2.20, defining > _GNU_SOURCE also had the effect of implicitly defining _BSD_SOURCE > and _SVID_SOURCE. https://www.man7.org/linux/man-pages/man7/feature_test_macros.7.html Fixes: ibm-openbmc#12 Fixes: 1523778 ("msgbuf: Add pldm_msgbuf_span_string_utf16()") Change-Id: I9206f7616740790a89366762cce11d3045471b97 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing ABI visibility from TESTING to
STABLE for a requester API pldm_close()
which uses pldm_transport_mctp_demux_destroy(),
a transport API whose visibility is also
changed likewise.
Use of pldm_close is demonstrated here-
https://gerrit.openbmc.org/c/openbmc/openpower-occ-control/+/66800
Tested: Error injection did not result in any
pldm_send() failure