-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix mypy error in ibis/backends/clickhouse/registry.py #2874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @napoles-uach
Hello @napoles-uach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-24 03:28:09 UTC |
Looks good, but it looks like you've got a conflict. Can you merge master ( |
@napoles-uach you need to run |
…into fix_mypy_error
thanks @napoles-uach |
Glad to contribute! |
xref #2856
Running
mypy ibis/backends/clickhouse/
gave this error belowibis/backends/clickhouse/registry.py:698: error: Incompatible types in assignment (expression has type "Dict[AnnotableMeta, Callable[[Any, Any, VarArg(Any)], Any]]", variable has type "List[AnnotableMeta]")
It was fixed by simply renaming in line 675 the list
_unsupported_ops
to_unsupported_ops_list
which is used in line 698 to build the Dictionary named_unsupported_ops