Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix mypy error in ibis/backends/clickhouse/registry.py #2874

Merged
merged 6 commits into from
Jul 25, 2021

Conversation

napoles-uach
Copy link
Contributor

@napoles-uach napoles-uach commented Jul 22, 2021

xref #2856
Running mypy ibis/backends/clickhouse/ gave this error below
ibis/backends/clickhouse/registry.py:698: error: Incompatible types in assignment (expression has type "Dict[AnnotableMeta, Callable[[Any, Any, VarArg(Any)], Any]]", variable has type "List[AnnotableMeta]")

It was fixed by simply renaming in line 675 the list _unsupported_ops to _unsupported_ops_list which is used in line 698 to build the Dictionary named _unsupported_ops

Copy link
Contributor

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @napoles-uach

@napoles-uach napoles-uach changed the title renamed list _unsupported_ops to avid incompatible type xref #2874 renamed list _unsupported_ops to avid incompatible type Jul 22, 2021
@napoles-uach napoles-uach changed the title xref #2874 renamed list _unsupported_ops to avid incompatible type xref #2874 renamed list _unsupported_ops to avoid incompatible type Jul 22, 2021
@napoles-uach napoles-uach changed the title xref #2874 renamed list _unsupported_ops to avoid incompatible type renamed list _unsupported_ops to avoid incompatible type Jul 22, 2021
@datapythonista datapythonista changed the title renamed list _unsupported_ops to avoid incompatible type CI: Fix mypy error in ibis/backends/clickhouse/registry.py Jul 23, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 23, 2021

Hello @napoles-uach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-24 03:28:09 UTC

@datapythonista
Copy link
Contributor

Looks good, but it looks like you've got a conflict. Can you merge master (git fetch upstream && git merge upstream/master) and resolve the conflict please?

@datapythonista datapythonista added clickhouse The ClickHouse backend ci Continuous Integration issues or PRs style labels Jul 23, 2021
@jreback jreback added this to the Next release milestone Jul 23, 2021
@datapythonista
Copy link
Contributor

@napoles-uach you need to run isort . in the project, and commit the changes that the command produces. We've got that command to keep the imports sorted in a deterministic way. Not sure if that's a good idea or not, but we've got it, so the CI won't be green until the imports are sorted with isort. Thanks!

@jreback jreback merged commit b639ca9 into ibis-project:master Jul 25, 2021
@jreback
Copy link
Contributor

jreback commented Jul 25, 2021

thanks @napoles-uach

@napoles-uach
Copy link
Contributor Author

thanks @napoles-uach

Glad to contribute!

@napoles-uach napoles-uach deleted the fix_mypy_error branch July 25, 2021 18:10
@cpcloud cpcloud removed this from the Next release milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs clickhouse The ClickHouse backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants