-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent conversion of non-plan OTP responses to POJO #74
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #74 +/- ##
============================================
- Coverage 31.94% 31.87% -0.08%
+ Complexity 207 203 -4
============================================
Files 81 81
Lines 2235 2237 +2
Branches 251 251
============================================
- Hits 714 713 -1
- Misses 1483 1485 +2
- Partials 38 39 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor typo, but looks good so approving.
|
||
public class OtpDispatcherResponseTest { | ||
@Test | ||
public void toStringShouldExludeResponseFieldIfNotCallingPlan() throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo Exlude: Exclude.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks.
Checklist
dev
before they can be merged tomaster
)Description
This PR fixes #73. A new test class and a
park_and_ride
mock response are added to guard against #73.