API Usage Chart Repair #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
approved these changes
Mar 6, 2024
| { | ||
| /* If we're specifying a USAGE_ID then we definitely don't want to | ||
| be creating API keys in that AWS environment! */ | ||
| isApiManagerEnabled() && USAGE_ID === null && ( |
There was a problem hiding this comment.
Should this be enabling account creation when USAGE_ID is null? Shouldn't it be the opposite?
There was a problem hiding this comment.
If USAGE_ID is set, then we don't have full access to the AWS instance, so probably shouldn't be creating AWS users and keys! If it is UNset, then we are safe to do so
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
amy-corson-ibigroup
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects some assumptions made during the development of these graphs. Most notable is a new
USAGE_IDfilter which lets you only show graphs and stats from a certain usage id.