Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gtfs-search): Display GTFS routes in search results. #933

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix(gtfs-search): Display GTFS routes in search results. #933

merged 2 commits into from
Mar 22, 2023

Conversation

binh-dam-ibigroup
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup commented Mar 14, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected => This PR is for MTC. A similar PR to dev will be made upon their approval
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Fix #932.

philip-cline
philip-cline approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me

miles-grant-ibigroup
miles-grant-ibigroup approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean! Thanks for implementing this

lib/gtfs/components/gtfs-search.js Outdated
(route.route_id === (typeof currentOption === 'object' ? currentOption && currentOption.value : currentOption))
// Keep routes whose ids are not excluded and that are not the one selected in the dropdown.
.filter(route => {
const isExcluded = excludedEntityIds && excludedEntityIds.includes(route.route_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we extract route.route_id and do a null check?

@binh-dam-ibigroup binh-dam-ibigroup merged commit eb3fb07 into mtc-deploy Mar 22, 2023
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-alert-route-selector branch March 22, 2023 12:23
@binh-dam-ibigroup binh-dam-ibigroup mentioned this pull request Mar 22, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

@philip-cline philip-cline philip-cline approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @philip-cline @miles-grant-ibigroup